Optimizing a lock-free ring buffer (david.alvarezrosa.com)
75 points by dalvrosa 2 days ago
dalvrosa a day ago
From 12M ops/s to 305 M ops/s on a lock-free ring buffer.
In this post, I walk you step by step through implementing a single-producer single-consumer queue from scratch.
This pattern is widely used to share data between threads in the lowest-latency environments.
loeg 5 hours ago
Your blog footer mentions that code samples are GPL unless otherwise noted. You don't seem to note otherwise in the article, so -- do you consider these snippets GPL licensed?
dalvrosa 5 hours ago
Actually I'm not sure. GPL was for source code of the website itself
I guess the code samples inside post are under https://david.alvarezrosa.com/LICENSE
But feel free to ping me if you need different license, quite open about it
nitwit005 28 minutes ago
It would be nice to have an example use case where the technique would show a benefit.
It seems relatively rare to have a single producer and consumer thread, and be worth polling a ring buffer.
ramon156 5 hours ago
Something to add to this; if you're focussing on these low-level optimizations, make sure the device this code runs on is actually tuned.
A lot of people focus on the code and then assume the device in question is only there to run it. There's so much you can tweak. I don't always measure it, but last time I saw at least a 20% improvement in Network throughput just by tweaking a few things on the machine.
dalvrosa 5 hours ago
Agreed. For benchmarking I used this <https://github.com/david-alvarez-rosa/CppPlayground/blob/mai...> which relies on GoogleBenchmark and pins producer/consumer threads to dedicated CPU cores
What else could be improved? Would like to learn :)
Maybe using huge pages?
dijit an hour ago
kernel tickrate is a pretty big one, most people don't bother and use what their OS ships with.
Disabling c-states, pinning network interfaces to dedicated cores (and isolating your application from those cores) and `SCHED_FIFO` (chrt -f 99 <prog>) helps a lot.
Transparent hugepages increase latency without you being aware of when it happens, I usually disable that.
Idk, there's a bunch but they all depend on your use-case. For example I always disable hyperthreading because I care more about latency than processing power- and I don't want to steal cache from my workload randomly.. but some people have more I/O bound workloads and hyperthreading is just and strict improvement in those situations.
dalvrosa an hour ago
kevincox 5 hours ago
Random idea: If you have a known sentinel value for empty could you avoid the reader needing to read the writer's index? Just try to read, if it is empty the queue is empty, otherwise take the item and put an empty value there. Similarly for writing you can check the value, if it isn't empty the queue is full.
It seems that in this case as you get contention the faster end will slow down (as it is consuming what the other end just read) and this will naturally create a small buffer and run at good speeds.
The hard part is probably that sentinel and ensuring that it can be set/cleared atomically. On Rust you can do `Option<T>` to get a sentinel for any type (and it very often doesn't take any space) but I don't think there is an API to atomically set/clear that flag. (Technically I think this is always possible because the sentinel that Option picks will always be small even if the T is very large, but I don't think there is an API for this.)
loeg 5 hours ago
Yeah, or you could put a generation number in each slot adjacent to T and a read will only be valid if the slot's generation number == the last one observed + 1, for example. But ultimately the reader and writer still need to coordinate here, so we're just shifting the coordination cache line from the writer's index to the slot.
kevincox 5 hours ago
I think the key difference is that they only need to coordinate when the reader and writer are close together. If that slows one end down they naturally spread apart. So you don't lose throughput, only a little latency in the contested case.
loeg 5 hours ago
pixelpoet 5 hours ago
Great article, thanks for sharing. And such a lovely website too :)
dalvrosa 5 hours ago
Thanks for the feedback <3
erickpintor 5 hours ago
Great post!
Would you mind expanding on the correctness guarantees enforced by the atomic semantics used? Are they ensuring two threads can't push to the same slot nor pop the same value from the ring? These type of atomic coordination usually comes from CAS or atomic increment calls, which I'm not seeing, thus I'm interested in hearing your take on it.
erickpintor 5 hours ago
I see you replied on comment below with:
> note that there are only one consumer and one producer
That clarify things as you don't need multi-thread coordination on reads or writes if assuming single producer and single consumer.
dalvrosa 5 hours ago
Exactly, that's right
dalvrosa 5 hours ago
Thanks! That's not ensured, optimizations are only valid due to the constraints
- One single producer thread
- One single consumer thread
- Fixed buffer capacity
So to answer
> Are they ensuring two threads can't push to the same slot nor pop the same value from the ring?
No need for this usecase :)
loeg 5 hours ago
This is a SPSC queue -- there aren't multiple writers to coordinate, nor readers. It simplifies the design.
jeffbee 28 minutes ago
It's lock-free because it uses ordered loads and stores, which is also how you implement locks. I find the semantic distinction unconvincing. The post is really about how slow the default STL mutex implementation is.
brcmthrowaway 42 minutes ago
Is there a C library that I can get these data structures for free?
Blackthorn 5 hours ago
I had what I thought was a pretty good implementation, but I wasn't aware of the cache line bouncing. Looks like I've got some updates to make.
dalvrosa 5 hours ago
Glad that it helps :)
brcmthrowaway an hour ago
Random q: What was the first cpu to support atomic instructions?
jeffbee 31 minutes ago
I don't know but the IBM 360 and the DEC PDP-10 both had them. Those are the earliest systems I ever saw.
sanufar 6 hours ago
Super fun, def gonna try this on my own time later
dalvrosa 5 hours ago
Feel free to share your findings
kristianp a day ago
This is in C++, other languages have different atomic primitives.
smj-edison 5 hours ago
Don't most people use C++11 atomics now? You have SeqCst, Release, Acquire, and Relaxed (with Consume deprecated due to the difficulty of implementing it). You can do loads, stores, and exchanges with each ordering type. Zig, Rust, and C all use the same orderings. I guess Java has its own memory model since it's been around a lot longer, but most people have standardized around C++'s design.
Which is a slight shame since Load-Linked/Store-Conditional is pretty cool, but I guess that's limited to ARM anyways, and now they've added extensions for CAS due to speed.
superxpro12 5 hours ago
I've taken an interest in lock-free queues for ultra-low power embedded... think Cortex-m0, or even avr/pic.
Things get interesting when you're working with a cpu that lacks the ldrex/strem assembly instructions that makes this all work. I think youre only options at that point are disable/enable interrupts. IF anyone has any insights into this constraint I'd love to hear it.
loeg 5 hours ago
loeg 5 hours ago
LL/SC is still hinted at in the C++11 model with std::atomic<T>::compare_exchange_weak:
https://en.cppreference.com/w/cpp/atomic/atomic/compare_exch...
jitl 6 hours ago
Really? Pretty much all atomics i’ve used have load, store of various integer sizes. I wrote a ring buffer in Go that’s very similar to the final design here using similar atomics.
dalvrosa 5 hours ago
Nice one, thanks for sharing. Do you wanna share the ring buffer code itself?
wat10000 5 hours ago
They generally map directly to concepts in the CPU architecture. On many architectures, load/store instructions are already guaranteed to be atomic as long as the address is properly aligned, so atomic load/store is just a load/store. Non-relaxed ordering may emit a variant load/store instruction or a separate barrier instruction. Compare-exchange will usually emit a compare and swap, or load-linked/store-conditional sequence. Things like atomic add/subtract often map to single instructions, or might be implemented as a compare-exchange in a loop.
The exact syntax and naming will of course differ, but any language that exposes low-level atomics at all is going to provide a pretty similar set of operations.
jitl 4 hours ago
dalvrosa 5 hours ago
blacklion 5 hours ago
JVM has almost the same (C++ memory model was modeled after JVM one, with some subtle fixes).
dalvrosa a day ago
Yeah, this is quite specific to C++ (at a syntax level)
amluto 5 hours ago
Huh? Other languages that compile to machine code and offer control over struct layout and access to the machine’s atomic will work the same way.
Sure, C++ has a particular way of describing atomics in a cross-platform way, but the actual hardware operations are not specific to the language.
dalvrosa 5 hours ago
Yeah, different languages will have different syntaxes and ways of using atomics
But at the hardware level all are kindof the same
JonChesterfield 5 hours ago
It's obviously, trivially broken. Stores the index before storing the value, so the other thread reads nonsense whenever the race goes against it.
Also doesn't have fences on the store, has extra branches that shouldn't be there, and is written in really stylistically weird c++.
Maybe an llm that likes a different language more, copying a broken implementation off github? Mostly commenting because the initial replies are "best" and "lol", though I sympathise with one of those.
loeg 5 hours ago
> It's obviously, trivially broken. Stores the index before storing the value, so the other thread reads nonsense whenever the race goes against it.
Are we reading the same code? The stores are clearly after value accesses.
> Also doesn't have fences on the store
?? It uses acquire/release semantics seemingly correctly. Explicit fences are not required.
JonChesterfield 5 hours ago
Push:
buffer_[head] = value;
head_.store(next_head, std::memory_order_release);
return true;
There's no relationship between the two written variables. Stores to the two are independent and can be reordered. The aq/rel applies to the index, not to the unrelated non-atomic buffer located near the index.
hrmtst93837 2 hours ago
loeg 5 hours ago
judofyr 5 hours ago
blacklion 5 hours ago
dalvrosa 5 hours ago
Sorry, but that's not actually true. There are no data races, the atomics prevent that (note that there are only one consumer and one producer)
Regarding the style, it follows the "almost always auto" idea from Herb Sutter
secondcoming 5 hours ago
If you enforce that the buffer size is a power of 2 you just use a mask to do the
if (next_head == buffer.size())
next_head = 0;
part